Tag-based revalidation inconsistent bahavior

Answered

Mini Lop posted this in #help-forum

Open in Discord

Mini LopOP

2023-11-21T01:46:25.000Z

Has anyone been able to make tag-based revalidation work consistently in the app router?

I'm using sanity and I have my queries tagged with a single tag, which is revalidated whenever I do an update in Sanity (with a webhook). But for some reason, my home page doesn't get the updated, while other pages do.

const res = await client.fetch<T>(
      getter(params),
      {},
      {
        next: {
          tags: ['sanity'],
        },
      },
    );

Answered by Eric Burel

revalidation is just plain buggy in 13

View full answer

92 Replies

2023-11-21T01:48:23.000Z

remember that there is page level cache and fetch cache

so you may need to revalidate the root page also

Mini LopOP

2023-11-21T01:49:20.000Z

So how are they related? I gets quite confusing with the app router

does Next statically generate the page, and when a request is revalidated it regenerates it?

But I'll try to add revalidatePath too, see if that helps

2023-11-21T01:50:59.000Z

have a look at the cache docs:: https://nextjs.org/docs/app/building-your-application/caching

Mini LopOP

2023-11-21T01:57:42.000Z

bit conflicted on this line

Calling the revalidatePath method revalidates the Data Cache, which in turn invalidates the Full Route Cache.

does this imply that revalidating the data cache also invalidates the full route cache?

or only when you call revalidatePath?

2023-11-21T01:59:25.000Z

i haven't used it enough to answer that from knowledge

Mini LopOP

2023-11-21T01:59:44.000Z

Alright, thanks anyway

2023-11-21T01:59:56.000Z

does it work with revalidatepath tho?

Mini LopOP

2023-11-21T02:00:37.000Z

still testing that

@Mini Lop does this imply that revalidating the data cache also invalidates the full route cache?

2023-11-21T02:04:46.000Z

yeah but it does sound like this is the intended case...

wait idk about the reverse (revalidatepath does the tags, but does it occure other way arround)

Mini LopOP

2023-11-21T02:36:28.000Z

revalidatePath didn't update it either

only deployment updates it

2023-11-21T02:37:46.000Z

hmm thats some weird cache then ðŸ˜

Mini LopOP

2023-11-21T02:42:45.000Z

oh, update

so, the page that's not properly updating has 3 cached requests

they all use the same revalidation tag

and only the first request remains stale

2023-11-21T02:43:53.000Z

hmm so second is correct new data

Mini LopOP

2023-11-21T02:43:57.000Z

yes

2023-11-21T02:44:41.000Z

ohh its doing that revalidate thingy then.... i forgot about it... i noticed it when specifying revalidate time and if it is over the time you get stale untill reload (as it recomputes the new at that time

Mini LopOP

2023-11-21T02:45:25.000Z

wait, didn't get what you mean

2023-11-21T02:45:41.000Z

like:

1. page with revalidate = 10
2. acceses page after 10 sec
3. reload page to see stale data
4. reloads again and new data (because it did the new page compute in step 3 but only show for new visit)

Mini LopOP

2023-11-21T02:48:00.000Z

but it stays stale

the data for the first request

literally infinite

until I redeploy

2023-11-21T02:49:04.000Z

oh

i don't know what other cache is there then...

Mini LopOP

2023-11-21T02:49:44.000Z

so, the page is not cached, that's clear

so it must be that single request

2023-11-21T02:51:07.000Z

can you show your code then... maybe you have something else caching it

Mini LopOP

2023-11-21T02:57:59.000Z

@Mini Lop Click to see attachment

2023-11-21T02:59:07.000Z

oh your export const dynamic = sanityDynamic is the prob i think

the value has to be static

as in a string

because nextjs doesn't run the code and just looks for it

Mini LopOP

2023-11-21T03:02:04.000Z

can't use env either?

2023-11-21T03:02:25.000Z

not that i know of

like you can't even do export const revalidate = 60 * 12

but in dev there is no cache anyway

Mini LopOP

2023-11-21T03:03:33.000Z

ok, let me try this

but, I actually want it to fallback to the default (which it would in this case, right?)

as in, cache

@riský but in dev there is no cache anyway

2023-11-21T03:04:14.000Z

*for some reason fetch cache exists actually (even though they make you think there is no cache)

Mini LopOP

2023-11-21T03:04:57.000Z

or you think it's best to do force-dynamic in prod?

and rely on the data cache

2023-11-21T03:05:50.000Z

im saying it prob doesn't do anything when using next dev

Mini LopOP

2023-11-21T03:06:36.000Z

so the env variable doesn't matter

@Mini Lop or you think it's best to do force-dynamic in prod?

2023-11-21T03:06:56.000Z

wait that makes it have no cache, i would say its still best having it as it can be faster cached

but both should work well too

Mini LopOP

2023-11-21T03:07:26.000Z

ideally it would be statically generated

and regenerated when the tag is revalidated

2023-11-21T03:07:55.000Z

yeah so if you leave it as default and revalidate tag and path, it should work in theory?

Mini LopOP

2023-11-21T03:08:05.000Z

in theory yes

let me remove the 'dynamic' and see if it interferes in some way

2023-11-21T03:08:32.000Z

as revalidatepath is meant to override that

Mini LopOP

2023-11-21T03:08:54.000Z

still strange, because all other pages have the exact same setup

2023-11-21T03:10:22.000Z

as like in this example:
* no cache specified in home: https://github.com/leerob/on-demand-isr/blob/main/app/page.tsx
* revalidate homepage: https://github.com/leerob/on-demand-isr/blob/main/app/api/webhook/route.ts#L33 (and next req would build latest)

Mini LopOP

2023-11-21T03:10:48.000Z

it's cached in dev when I remove it ðŸ˜„

maybe tag revalidation and path revalidation don't work well together

2023-11-21T03:13:06.000Z

nextjs cache has changed too much since i last played with it ðŸ˜

Mini LopOP

2023-11-21T03:14:21.000Z

so I can confirm that export const dynamic = sanityDynamic; does work

and also has effect in dev

@Mini Lop so I can confirm that export const dynamic = sanityDynamic; does work

2023-11-21T03:15:15.000Z

it shouldn't do much if working based on what i was toled some time ago

@Mini Lop and also has effect in dev

2023-11-21T03:15:25.000Z

dev may not do static analysis tho

Mini LopOP

2023-11-21T03:33:34.000Z

so, funny thing, when I deploy, the data is updated

when I do revalidatePath, the data is stale again

wth

2023-11-21T03:34:26.000Z

You said when you update something in sanity, so is it triggering a webhook that hits a route handler that calls revalidatePath?

^ because this behavior does not work at all for me

Mini LopOP

2023-11-21T03:35:36.000Z

yes

can you show me your fetch code, because there's also a mistake in the sanity-next doc

2023-11-21T03:36:13.000Z

Yeah, the revalidate functions straight up do not work in Route Handlers.

at least in my experience

@Mini Lop can you show me your fetch code, because there's also a mistake in the sanity-next doc

2023-11-21T03:37:03.000Z

I'm revalidating path since my data is fetched from the CMS client, it's not tagged.

2023-11-21T03:37:09.000Z

btw we are using latest nextjs right?

2023-11-21T03:37:24.000Z

yeah

Mini LopOP

2023-11-21T03:37:51.000Z

I'm using 13.4.4

I can try 14

@Mini Lop I can try 14

2023-11-21T10:18:39.000Z

yes try 14

2023-11-21T10:18:45.000Z

revalidation is just plain buggy in 13

Answer

2023-11-21T10:18:51.000Z

so you might just be hitting bugs

I couldn't have revalidateTag to work on v13 but it worked fine in v14

Mini LopOP

2023-11-21T13:38:07.000Z

yep, that did the trick

@Eric Burel I couldn't have revalidateTag to work on v13 but it worked fine in v14

2023-11-22T02:06:47.000Z

how about revalidate path? I can't seem to get that to work from a route handler trying to revalidate a fully static page.

I'm on the latest version