also tried replacing the popup fn with redirect fn still getting same error

if the user exists and you can see it in the network tab, i think you should try moving your console.log inside the unsubscribe

there is no user

so how do you know the login was successful?

because I can see the user been registered in the firebase

did you try this?

the user you're logging is the user in the useState not the user in the onAuthStateChanged callback

or better still add the user in the dep array in your useEffect

import { useEffect } from "react";
import { useAuth } from "./auth";
import { useRouter } from "next/router";

export default function withAuth(Component) {
return function WithAuthComponent(props) {
const { loading, user } = useAuth();
const router = useRouter();
useEffect(() => {
if (loading && !user) {
router.push("/login");
} else if (!loading && user) {
router.push("/");
}
}, [loading, user, router]);

if (loading) return <div>Loading...</div>;
return <Component {...props} />;
};
}
am i doing something wrong in this

not this useEffect

this

useEffect(() => {
    const unsubscribe = onAuthStateChanged(auth, (user) => {
      setUser(user);
      setLoading(false);
    });
    console.log(user ?? "no data");
    return () => unsubscribe();
  }, []);

so I'm getting mulitple user objects idk why and also the redirect is not working after clicking on login button

I think something is wrong either in auth.js or withAuth.js

yes, with your useEffects

what does your useEffect look like in both places atm?

useEffect(() => {
const unsubscribe = onAuthStateChanged(auth, (user) => {
setUser(user || null);
setLoading(false);
});
return () => unsubscribe();
}, []);

try commenting out the second useEffect and log in again and see if you still get an infinite loop

import withAuth from "@/provider/withAuth";
import "@/styles/globals.css";

function App({ Component, pageProps }) {
return <Component {...pageProps} />;
}

export default withAuth(App);

means the problem is with the useEffect

why not move your redirect to the login function and handle everything there since you already have your loading states there too

didn't work srry

but thanks you were the only one who came for support 🙂